A bug has been discovered in make_tides for the versions 2.0.0 and 2.0.1 : the
phase correction on date is applied even when disabled.
This currently causes incorrect phases when using the TIDES_MAS option in
CROCO: even if SSH correction is disabled, a phase correction is still
applied and then recomputed in Fortran, leading to wrong results.
A correction will be provided in the next release.
hi,
crocotides.py (12.5 KB)
Thank you for your kind reporting . can you please check the file i attached. i fixed it correctly or not? I am new in forum. can you please help me. i modified Line 51, 134, and 262-272.
Thank you.
Hello,
Thank you for your input.
I don’t think it is necessary to add a new boolean parameter use_tides_mas, since the existing parameters correction_ssh and correction_uv are sufficient.
The issue lies in the in the apply_correction function, which currently does not distinguish between SSH and UV. As a result, correction is applied for both even if to only one of them is asked for.
Furthermore, if no correction are asked for, a phase correction is still there (should be 0).
An issue has been opened on the croco_pytools GitLab project. I will post an update here once it is fixed and merged into the main branch.
ok. thank you.
crocotides.py (12.6 KB)