# Revision history [back]

Hi Anna,

In your new cppdefs.h, multiple things need to be corrected:

The bigger issues are :

You have undef all the advection terms, which makes no sense... You should put them back :

define UV_HADV_UP3


You have also undef the requested bulk fluxes for momentum, you should put them back:

define BULK_FAIRALL
define BULK_LW
define BULK_SMFLUX


Other minor things that should be removed :

define SPLIT_EOS


It is useless in your new cppdefs.h because it is defined in cppdefs_dev.h when NONLIN_EOS is defined (as it is your case)

define OBC_M2FLATHER


It is also already defined in cppdefs_dev.h.

Now some things I have noted in your new param.h:

parameter (LLm0=332,   MMm0=370,   N=32)


While, in your old param.h the grid parameters were:

parameter (LLm0=248, MMm0=248,  N=32)


Also the number of tasks for openmp are not the same in the old and new versions of param.h (8 vs 80).

One last thing is that in your new cppdefs.h, you have defined NEW_S_COORD. It is ok, but have you take care when preparing your files during pre-processing to use this in crocotools_param.m?

vtransform =  2.


Hi Anna,

In your new cppdefs.h, multiple things need to be corrected:

The bigger issues are :

You have undef all the advection terms, which makes no sense... You should put them back :

define UV_HADV_UP3


You have also undef the requested bulk fluxes for momentum, you should put them back:

define BULK_FAIRALL
define BULK_LW
define BULK_SMFLUX


Other minor things that should be removed :

define SPLIT_EOS


It is useless in your new cppdefs.h because it is defined in cppdefs_dev.h when NONLIN_EOS is defined (as it is your case)

define OBC_M2FLATHER


It is also already defined in cppdefs_dev.h.

Now some things I have noted in your new param.h:

parameter (LLm0=332,   MMm0=370,   N=32)


While, in your old param.h the grid parameters were:

parameter (LLm0=248, MMm0=248,  N=32)


Also the number of tasks for openmp are not the same in the old and new versions of param.h (8 vs 80).

One last thing is that in your new cppdefs.h, you have defined NEW_S_COORD. It is ok, but have you take care when preparing your files during pre-processing to use this in crocotools_param.m?

vtransform =  2.